+- ispCP - Board - Support (http://www.isp-control.net/forum)
+-- Forum: ispCP Omega Support Area (/forum-30.html)
+--- Forum: Usage (/forum-34.html)
+--- Thread: Error 500 (/thread-7637.html)
RE: Error 500 - kilburn - 08-29-2009 09:51 PM
So you think that the following step from my previous example is not problematic, right?
Code:
6. rqst-mngr launches mbox-mngr, who tries to add mails for both "domain1.tld" (no problem) _and_ "domain2.tld" (which has not been created yet). Thereafter, bad things _may_ happen.RE: Error 500 - sci2tech - 08-29-2009 11:28 PM
The email to postfix/courier will be added before domain will be added in bind configure file. This will not be a problem as long as domain will be added immediately (some "query was empty" or some error in gui, not critical). But problem will be generated by htaccess*-mgr witch will try to write files in inexistent folders. This can be corrected in rqst-mngr modifying to perform this actions only for domains that have ok status (I refer to mail/subdomain/alias/htaccess actions).
RE: Error 500 - kilburn - 08-30-2009 03:28 AM
Quote:But problem will be generated by htaccess*-mgr witch will try to write files in inexistent folders. This can be corrected in rqst-mngr modifying to perform this actions only for domains that have ok status (I refer to mail/subdomain/alias/htaccess actions).
Now you got my point
I suspect there may be other issues like the one you pointed out, so the safest bet if we want to release trunk as stable is simply properly locking the gui too. This will yield worse performance, but at least we will make sure that we don't have to deal with nasty hard-to-find race condition bugs.Maybe on future versions we can improve the backend scripts and remove the big giant lock (bsd anyone?
). I'll implement it ok?
RE: Error 500 - sci2tech - 08-30-2009 03:50 AM
Indeed I understand what you point to
. Well, when we will start to code a new verision some proper planning will be needed.
RE: Error 500 - kilburn - 08-30-2009 06:53 PM
(Properly) fixed in r1952. I've been able to remove most of the gui lock calls, see the commit message for further details.
RE: Error 500 - sci2tech - 08-30-2009 06:56 PM
I`ll test it today, after I finish update procedure
Nice work