+- ispCP - Board - Support (http://www.isp-control.net/forum)
+-- Forum: ispCP Omega Development Area (/forum-1.html)
+--- Forum: General discussion (/forum-11.html)
+--- Thread: How to submit patch (/thread-1017.html)
How to submit patch - traise - 07-22-2007 12:11 AM
Hi dear developers,
I got a problem during ispcp-setup. The script did not accept my FQDN hosting.my.domain.com, so I made a modification to it in order to handle long hostname cause for the moment the script only accept this form "my.domain.com".
[attachment=151]
I've send it to malte@... but I did not get any feedback.
What's the best way to send you patch ?
In addition I would like to know how can I get access to SVN in order to help you in ispCPOmega project.
I'm working for a swiss company who provide hosting so I am very interested to participate to this project.
Thank you,
RE: How to submit patch - BeNe - 07-22-2007 02:36 AM
Hello traise,
the best way is to open a Ticket --> here . Write your Info down and Upload your Diff to the Ticket.
For the SVN-Access, check RatS or ephigenie.
It would be perfect if you can help here
Greez BeNe
RE: How to submit patch - raphael - 07-22-2007 08:22 AM
You should created the patches by using diff -urN; otherwise it is more complicated to be accepted (specially when the file has been modified)
RE: How to submit patch - RatS - 07-22-2007 07:16 PM
with latest trunk your Hostname should work; it's
Code:
if ($rdata =~ /^((([\w][\w-]{0,253}[\w])\.)*)([\w][\w-]{0,253}[\w])\.([a-zA-Z]{2,6})$/) {
$main::ua{'hostname'} = $rdata;
$main::ua{'hostname_local'} = ( ($1) ? $1 : $4);
$main::ua{'hostname_local'} =~ s/^([\w][\w-]{0,253}[\w])\.(.*?)$/$1/;