Changeset 3240 for trunk/engine/backup/ispcp-backup-all

Timestamp:

08/29/10 22:16:32 (21 months ago)

Author:

benedikt

Message:

• [ENGINE] Security Fix #2440: Backup script will restore forged backup [Part II] (Thanks to Daniel)
• [GUI] Changed: Orderpanel 'State' is not longer a required field
• [GUI] Changed: Oder of address fields changed
• [GUI] Fixed #2174: Several issues for the Ticket Support System
• [GUI] Refactored: Ticket System of (part I/client)
• [LANGUAGES] Updates German Language File

File:

• trunk/engine/backup/ispcp-backup-all (modified) (9 diffs)

trunk/engine/backup/ispcp-backup-all

@@ -184 +184 @@
 
                 $rs = sys_command_rs($db_backupcmd);
-                if( $rs != 0 ){
+                if($rs != 0) {
                         push_el(\@main::el, 'backup_sql()', "Domain $dmn_name: ERROR: Failed to backup database $db_name!");
                         send_error_mail('backup_sql()', "Domain $dmn_name: ERROR: Failed to backup database $db_name!");
@@ -192 +192 @@
 
                 $rs = setfmode("$db_backup_file", 0, 0, 0444);
-                if( $rs != 0 ){
+                if($rs != 0) {
                         push_el(\@main::el, 'backup_sql()', "Domain $dmn_name: ERROR: Can not chmod 0444 uid: 0 gid: 0 file $db_backup_file!");
                         send_error_mail('backup_sql()', "Domain $dmn_name: ERROR: Can not chmod 0444 uid: 0 gid: 0 file $db_backup_file!");
@@ -200 +200 @@
 
                 $rs = sys_command($db_compresscmd);
-                if ($rs != 0){
+                if ($rs != 0) {
                         push_el(\@main::el, 'backup_sql()', "Domain $dmn_name: ERROR: Error while executing  $db_compresscmd!");
                         send_error_mail('backup_sql()', "Domain $dmn_name: ERROR: Error while executing $db_compresscmd!");
@@ -280 +280 @@
                         #todo test mode and adjust only if necessary
                         $rs = setfmode($dmn_backup_dir, 0, 0, 0555);
-                        if ($rs != 0){
+                        if ($rs != 0) {
                                 push_el(\@main::el, 'backup_all_engine()', "Domain $dmn_name: Error while changing mode to 0555 uid: 0: 0 for $dmn_backup_dir!");
                                 send_error_mail('backup_all_engine()', "Domain $dmn_name: Error while changing mode to 0555 uid: 0 gid: 0 for $dmn_backup_dir!");
@@ -312 +312 @@
 
                                         $rs = sys_command("$cmd_rm -rf $www_dir/$backup_filename.log");
-                                        if ($rs != 0){
+                                        if ($rs != 0) {
                                                 push_el(\@main::el, 'backup_all_engine()', "Domain $dmn_name: Error while executing $cmd_rm -rf $www_dir/$backup_filename.log!");
                                                 send_error_mail('backup_all_engine()', "Domain $dmn_name: Error while executing $cmd_rm -rf $www_dir/$backup_filename.log!");
@@ -318 +318 @@
 
                                         $rs = sys_command("$cmd_rm -rf $dmn_backup_dir/$dmn_name-*.tar.*");
-                                        if ($rs != 0){
+                                        if ($rs != 0) {
                                                 push_el(\@main::el, 'backup_all_engine()', "Domain $dmn_name: Error while executing $cmd_rm -rf $dmn_backup_dir/$dmn_name-*.tar.*!");
                                                 send_error_mail('backup_all_engine()', "Domain $dmn_name: Error while executing $cmd_rm -rf $dmn_backup_dir/$dmn_name-*.tar.*!");
@@ -324 +324 @@
 
                                         $rs = sys_command("$cmd_mv -f $www_dir/$backup_filename $dmn_backup_dir");
-                                        if ($rs != 0){
+                                        if ($rs != 0) {
                                                 push_el(\@main::el, 'backup_all_engine()', "Domain $dmn_name: Error while executing $cmd_mv -f $www_dir/$backup_filename $dmn_backup_dir!");
                                                 send_error_mail('backup_all_engine()', "Domain $dmn_name: Error while executing $cmd_mv -f $www_dir/$backup_filename $dmn_backup_dir!");
@@ -330 +330 @@
 
                                         $rs = setfmode("$dmn_backup_dir/$backup_filename", 0, 0, 0444);
-                                        if ($rs != 0){
+                                        if ($rs != 0) {
                                                 push_el(\@main::el, 'backup_all_engine()', "Domain $dmn_name: Error while changing mode to 0444 uid: 0 gid: 0 for $dmn_backup_dir/$backup_filename!");
                                                 send_error_mail('backup_all_engine()', "Domain $dmn_name: Error while changing mode to 0444 uid: 0 gid: 0 for $dmn_backup_dir/$backup_filename!");
@@ -344 +344 @@
                                         if ( -e "$www_dir/$backup_filename" ) {
                                                 $rs = del_file("$www_dir/$backup_filename");
-                                                if ($rs != 0){
+                                                if ($rs != 0) {
                                                         push_el(\@main::el, 'backup_all_engine()', "Domain $dmn_name: Error while removing file $www_dir/$backup_filename!");
 # we don't need a second mail...                        send_error_mail('backup_all_engine()', "Domain $dmn_name: Error while removing file $dmn_dir/$backup_filename!");