Ticket #1255 (closed defect: fixed)
please commit these patches for an better useful/readable database update files
|Reported by:||anonymous||Owned by:|
|Priority:||minor||Milestone:||ispCP ω 1.0 - RC5|
|Component:||Frontend (GUI)||Version:||ispCP ω 1.0.0 - RC4|
1st modified file: ispcp/gui/include/database-update-functions.php
The first diff lines I reduces the sql-SELECT-complexity a little bit.
The last lines remove an unnecessary if-clause. Cause the while loop with checkNewRevisionExists() already checks if the function exists. Furthermore i removed the brackets after the variable $functionName. This diff enables that you can save 5 function-calls and 1 SQL-SELECT for each loop run.
2nd modified file: ispcp/gui/admin/database_update.php
Currently it is checked 2 times if an database update exists. With this second patch I merged the two if clause to one. This saves circa 5 function calls and one SQL-execution.
These are patches against r1151.