Ticket #1479 (closed defect: fixed)
Use cmp instead of diff (at least for the logs)
|Reported by:||aseques||Owned by:|
|Priority:||major||Milestone:||ispCP ω 1.0 - RC7|
|Component:||Backend (Engine)||Version:||ispCP ω 1.0.0 - RC6|
When checking for the mail logs the perl script uses a diff -q -a
Everytime the message "Files /var/log/ispcp/mail.log and /var/log/ispcp/mail.log.prev differ" gets logged and if you have an aliase for the root messages, your mailbox will get crowded of those messages. Since the only thing being done is the comparition. Instead of diff, it would be better to use cmp -s
cmp is part of the same package, so it doesn't introduce new dependencies, and would allow for an easier track of system problems.
The workaround would be to >/dev/null the result, but the moment there's a real problem, you wouldn't notice.