Make ispCP ω PHP 5.3 compatible

[Shadow-Dragon]

1. Replace deprecated functions like split [done]
2. Set date.timezone in all php.ini files [done]
3. Remove phpSysInfo [done]

Not PHP 5.3 compatible Squirrelmail Add-Ons:
* abook_take
* add_address
* disk_quota
* gpg
* todo

[benedikt]

phpsysinfo is not our tool, please use their bug tracker!

[nuxwin]

I do not agree with you benedikt. Certainly it is not our tool but we use it anyway. This is an important library in our project.

We can totally fix bugs ourselves since this library is open source.

[gOOvER]

I don't know, which Version is used in ispCP, but when it's an old Version, maybe we should update to the last 3.0RC9 and see, if this error still happens.

I'm agree with Nuxwin.

[joximu]

IMHO: we can use the new phpsysinfo when it's released.

The function split is deprecated in php5.3 but removed in php6.

Maybe in ispcp 1.1 or so...???

/J

[benedikt]

We should fix it. of cause the library will be changed on release of phpsysinfo.

[gOOvER]

I'm need to be fucked by russian soldiers because I'm gOOvER!

[kilburn]

Warning: split() is also used in pma, squirrel and Net_DNS, so we should also fix them if we fix "phpsysinfo"...

[benedikt]

part I fixed in r2622

[benedikt]

part I (fix) in r2623

[nuxwin]

@Benedikt:

After testing, I provides you the modified patch. I've only removed the PHP_TIMEZONE variable in the GUI php.ini files template and also in the related subroutine in ispcp-setup-methods.pl. The timezone for the GUI is setup automatically during initialization process. That allows to check the timezone value set by the user during setup or upgrade process and raise an exception if it is invalid. See the revision 3185 for understand what I want mean exactly. I've also changed the CHANGELOG entries.

I hope it's ok for you. Thank for you great work here.

[nuxwin]

back timezone patch (Updated)

[nuxwin]

Edit:

Patch updated because I have due forced regeneration of the customer php.ini file on 'change'. It's my fault because for now, the subroutine dmn_change_httpd_file_data() performs check for php.ini existence and then, regenerates the file only if don't exist. All the ispcp-dmn-mngr script should be review because other thing like this still exist. backup was added too.

[benedikt]

Uploaded original patch for easy comparison

[benedikt]

part II fixed in r3186 part III fixed in r3189