Ticket #2053 (closed defect: fixed)
Make ispCP ω PHP 5.3 compatible
| Reported by: | Shadow-Dragon | Owned by: | benedikt |
|---|---|---|---|
| Priority: | normal | Milestone: | ispCP ω 1.0.7 |
| Component: | Frontend (GUI) | Version: | ispCP ω nightly build |
| Severity: | Easy | Keywords: | |
| Cc: |
Description (last modified by benedikt) (diff)
- Replace deprecated functions like split [done]
- Set date.timezone in all php.ini files [done]
- Remove phpSysInfo [done]
Not PHP 5.3 compatible Squirrelmail Add-Ons:
- abook_take
- add_address
- disk_quota
- gpg
- todo
Attachments
-
back_timezone.patch
(19.9 KB) -
added by nuxwin 18 months ago.
- back timezone patch (Updated)
-
timezone.patch
(23.6 KB) -
added by benedikt 18 months ago.
- Uploaded original patch for easy comparison
Change History
comment:1 Changed 2 years ago by benedikt
- Status changed from new to closed
- Resolution set to wontfix
comment:3 Changed 2 years ago by nuxwin
I do not agree with you benedikt. Certainly it is not our tool but we use it anyway. This is an important library in our project.
We can totally fix bugs ourselves since this library is open source.
comment:4 Changed 2 years ago by gOOvER
I don't know, which Version is used in ispCP, but when it's an old Version, maybe we should update to the last 3.0RC9 and see, if this error still happens.
I'm agree with Nuxwin.
comment:5 Changed 2 years ago by joximu
IMHO: we can use the new phpsysinfo when it's released.
The function split is deprecated in php5.3 but removed in php6.
Maybe in ispcp 1.1 or so...???
/J
comment:6 Changed 2 years ago by benedikt
- Status changed from closed to reopened
- Resolution wontfix deleted
We should fix it. of cause the library will be changed on release of phpsysinfo.
comment:7 Changed 2 years ago by gOOvER
I'm need to be fucked by russian soldiers because I'm gOOvER!
comment:8 Changed 2 years ago by kilburn
Warning: split() is also used in pma, squirrel and Net_DNS, so we should also fix them if we fix "phpsysinfo"...
comment:12 Changed 2 years ago by benedikt
- Owner set to benedikt
- Status changed from reopened to new
comment:15 Changed 2 years ago by benedikt
- Description modified (diff)
- Summary changed from php5.3 split() error to Make ispCP ω PHP 5.3 compatible
comment:17 Changed 2 years ago by benedikt
part I fixed in r2622
comment:18 Changed 2 years ago by benedikt
part I (fix) in r2623
comment:25 Changed 18 months ago by nuxwin
@Benedikt:
After testing, I provides you the modified patch. I've only removed the PHP_TIMEZONE variable in the GUI php.ini files template and also in the related subroutine in ispcp-setup-methods.pl. The timezone for the GUI is setup automatically during initialization process. That allows to check the timezone value set by the user during setup or upgrade process and raise an exception if it is invalid. See the revision 3185 for understand what I want mean exactly. I've also changed the CHANGELOG entries.
I hope it's ok for you. Thank for you great work here.
comment:26 Changed 18 months ago by nuxwin
Edit:
Patch updated because I have due forced regeneration of the customer php.ini file on 'change'. It's my fault because for now, the subroutine dmn_change_httpd_file_data() performs check for php.ini existence and then, regenerates the file only if don't exist. All the ispcp-dmn-mngr script should be review because other thing like this still exist. backup was added too.
Changed 18 months ago by benedikt
-
attachment
timezone.patch
added
Uploaded original patch for easy comparison
comment:27 Changed 18 months ago by benedikt
- Status changed from assigned to closed
- Resolution set to fixed
phpsysinfo is not our tool, please use their bug tracker!