Ticket #2093 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

The main index.php page doesn't deal properly with ssl controlpannel

Reported by: aseques Owned by: benedikt
Priority: normal Milestone: ispCP ω 1.0.4
Component: Frontend (GUI) Version: ispCP ω 1.0.3
Severity: Don't know Keywords:
Cc:

Description

In 1.0.3, there is the shortcuts to pma, webmail, and filemanager. To generate the links is being used the variable $_SERVERHTTPS?, the problem with this is that it doesn't work when using a port different of 443, so the links are generated as http, even if the panel is under https. I'd suggest, using relative links instead, because it doesn't break anything on ordinary use, and allow to use ports (i.e. 8443) under ssl. I attach the patch that worked for me, in rev 2332

Attachments

index_php_relative_links.patch Download (1.9 KB) - added by aseques 2 years ago.

Change History

Changed 2 years ago by aseques

comment:1 Changed 2 years ago by benedikt

  • Milestone changed from ispCP ω 1.0.3 to ispCP ω 1.1.0

code freeze.

comment:2 Changed 2 years ago by benedikt

  • Milestone changed from ispCP ω 1.1.0 to ispCP ω 1.0.4

comment:3 Changed 2 years ago by benedikt

  • Status changed from new to closed
  • Resolution set to fixed

added in r2501. Thanks for the patch, works fine!

comment:4 Changed 2 years ago by nuxwin

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:5 Changed 2 years ago by nuxwin

  • Owner set to benedikt
  • Status changed from reopened to new

comment:6 Changed 2 years ago by nuxwin

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.