Ticket #2152 (closed malfunction: fixed)

Opened 2 years ago

Last modified 2 years ago

Wrong limited count in reseller gui

Reported by: TheCry Owned by: TheCry
Priority: major Milestone: ispCP ω 1.0.4
Component: Frontend (GUI) Version: ispCP ω trunk
Severity: Medium Keywords:
Cc:

Description

In the reseller gui you will see the wrong counters for limitation. After adding or editing a user the counter field of the reseller (current_email, currentftp,....) where updated with the wrong counters.

Change History

comment:1 Changed 2 years ago by TheCry

  • Owner set to TheCry
  • Status changed from new to assigned

comment:2 Changed 2 years ago by TheCry

I've create a patch. nuxwin is testing it.

comment:3 Changed 2 years ago by nuxwin

ok, I've tested

Found bug

I've created on reseller with 20 mail accounts as limit

I've created custommer account with 10 mail accounts as limit

I've disabled the default mails counting via admin settings.

I've create new mail account via customer frontend.

The BUG is : 0 / 10 of 20

So, the mail account created by customer is not counted.

Please, review your patch. And I'll re-check after.

comment:4 Changed 2 years ago by nuxwin

Note: When I enable the 'Count default E-Mail addresses' setting via admin settings, all accounts created are counted. :

4 / 10 of 20

  • 'abuse@…', 'postmaster@…' and 'webmaster@…' are default mail accounts.
  • the customer mail account in my case is 'admin@…'

If the setting 'Count default E-Mail addresses' is enabled all mail account must be counted, otherwise, only customer created mail account must be counted.

So, please, do not confuse default mail count (abuse, postmaster, webmaster...) with mail accounts created by customer.

comment:5 Changed 2 years ago by TheCry

Stop...

4 / 10 of 20

I don't talk about the first number! This counter works correct. Only the second counter. Logical is this the counter which counts the given limit to the customer!!! Whatever you set with the 'Count default E-Mail addresses' this counter doesn't change. Only if you change the limit of a customer or you add a customer!

comment:6 Changed 2 years ago by nuxwin

For the record:

(15:56:21) TheCry: hello
(15:59:03) nuxwin: Re
(15:59:13) TheCry: oki
(15:59:20) nuxwin: I want not know if you talk about that or not
(15:59:33) nuxwin: I said, bug detected so, should be fixed
(15:59:35) nuxwin: now
(15:59:37) nuxwin: I explain
(15:59:43) TheCry: ahhhhh
(16:00:01) nuxwin: the first number
(16:00:06) nuxwin: is related to the real 
(16:00:11) nuxwin: number of count used
(16:00:13) nuxwin: right 
(16:00:15) nuxwin: ?
(16:00:17) TheCry: yes
(16:00:20) nuxwin: ok
(16:00:24) nuxwin: currently
(16:00:26) nuxwin: if the setting
(16:00:37) nuxwin: 'count default email adresse' is set to
(16:00:40) nuxwin: 'disable'
(16:00:51) nuxwin: all mails accounts are not counted 
(16:00:53) nuxwin: so please
(16:00:55) nuxwin: fix it
(16:01:08) TheCry: ahhhh... now i understand
(16:01:14) nuxwin: great
(16:01:16) nuxwin: lol
(16:01:18) TheCry: :)
(16:01:33) nuxwin: See my related comment on trac
(16:01:36) nuxwin: ;-)
(16:01:42) TheCry: 2 weeks ago i changed some files with this bug
(16:01:50) nuxwin: lol
(16:01:55) nuxwin: no problem
(16:01:56) TheCry: so i forgot this file
(16:02:01) nuxwin: fix it and provide me new patch
(16:02:11) nuxwin: test it before
(16:02:13) nuxwin: ;-)
(16:02:23) TheCry: ok... in the next 1 hour
(16:02:29) nuxwin: no problem my dear
(16:02:30) TheCry: yes sir.. :)
(16:02:33) nuxwin: :'(;-)
(16:02:36) TheCry: lol

comment:7 Changed 2 years ago by nuxwin

  • Priority changed from major to Working Copy (Commit ASAP)

comment:8 Changed 2 years ago by nuxwin

  • Priority changed from Working Copy (Commit ASAP) to major
  • Status changed from assigned to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.