Ticket #2159 (closed malfunction: fixed)

Opened 2 years ago

Last modified 2 years ago

Reseller can update to small hosting plan even if client use more resources

Reported by: chebe Owned by: fisa4
Priority: major Milestone: ispCP ω 1.0.4
Component: Frontend (GUI) Version: ispCP ω trunk
Severity: Easy Keywords:
Cc:

Description

In latest clean installed trunk I can change hosting plan with small disk space for site which have more disk space. Somebody check trunk if it works or not? o_O Disaster!

Change History

comment:1 Changed 2 years ago by benedikt

  • Milestone changed from Working to ispCP ω 1.0.4

comment:2 Changed 2 years ago by chebe

I mean user can update hosting package to smaller and reseller can add this order without any errors.

comment:3 Changed 2 years ago by nuxwin

  • Owner set to nuxwin
  • Status changed from new to assigned

comment:4 Changed 2 years ago by nuxwin

  • Owner changed from nuxwin to fisa4
  • Status changed from assigned to new

comment:5 Changed 2 years ago by fisa4

  • Status changed from new to assigned

comment:6 Changed 2 years ago by TheCry

I can't reproduce it! I've create 2 hostingplans. One with all unlimited and disklimit to 100MB. The other all unlimited and disklimit to 10MB. Now i create a user mit the first hostingplan! I uploaded a file with 70MB and run ./ispcp-dsk-quota to update the quota. Now i looked into the customer panel and tried to change to the second hosting plan. Error: You have more disk space in use than the new hosting plan limits.

Every seems to be ok.

But i'd created a third hostingplan with all unlimited and disklimit 200MB. I can't change to this. No error... Click on the Link and the browser jumps on the top!

comment:7 Changed 2 years ago by zothos

  • Priority changed from blocker to major
  • Type changed from defect to malfunction
  • Severity changed from Don't know to Hard

comment:8 Changed 2 years ago by benedikt

fisa4, any news? Do you have a patch? Need help?

comment:9 follow-up: ↓ 11 Changed 2 years ago by fisa4

Not a patch yet, but the solution:

in line 410 (between "}" and "$rs->MoveNext?();" It should look like this:

            $i++;
        }
        $purchase_text = tr('Purchase');  // add this line
        $purchase_link = 'order_id';      // add this line
        $rs->MoveNext();
    } 

comment:10 Changed 2 years ago by fisa4

  • Severity changed from Hard to Easy

comment:11 in reply to: ↑ 9 ; follow-up: ↓ 12 Changed 2 years ago by benedikt

Which file?

Replying to fisa4:

Not a patch yet, but the solution:

in line 410 (between "}" and "$rs->MoveNext?();" It should look like this:

comment:12 in reply to: ↑ 11 Changed 2 years ago by benedikt

Replying to benedikt:

Which file?

Found it: client/hosting_plan_update.php. I will test it.

comment:13 Changed 2 years ago by benedikt

  • Status changed from assigned to closed
  • Resolution set to fixed

fixed in r2599. Thank you to fisa4.

Note: See TracTickets for help on using tickets.