apache logger should be able to use the improvements of logio in http accounting

[aseques]

There's a module for apache (normally build-in) that gives us two new variables on our logs. %I %O. With the attached patch, instead of writing %b into /var/log/apache2/example.com.traf, we write %I+%O, wich is exactly the amount downloaded/uploaded for the client.

More info here:  http://www.isp-control.net/forum/thread-8721.html

[aseques]

Another (better) approach would be to create a regexp that could handle both a LogFile? with %I %O or without them, so we hadn't to add another option on ispcp.conf

[kilburn]

Hey aseques, could you please post the "CustomLog?" directive that you use with this patch? Thanks!

[aseques]

This is the relevant section:

#
# Log processing.
#

LogFormat "%B" traff
LogFormat "%v %b %h %l %u %t \"%r\" %>s %b \"%{Referer}i\" \"%{User-Agent}i\" %I %O" ispcplog

CustomLog "| /var/www/ispcp/engine/ispcp-apache-logger" ispcplog
ErrorLog "| /var/www/ispcp/engine/ispcp-apache-logger -e"

As you can see, the only changes in apache2/ispcp.conf are the added %I %O

[kilburn]

Patch to enable mod_logio accounting in debian (must ispcp-update to make it effective)

[benedikt]

which of the patches should be applied? any modules needed?

[aseques]

I am reworking the patch, so there's no need to put a new variable in ispcp.conf and at the same time have backwards compatibility. When I am at job on monday I will post the patch.

[aseques]

I updated the attachment, with the ALMOST working patch. Basically, it consists in two parts:
.- The change for the httpd.conf (logio is compiled build-in in most distros, also de *BSD ones) so logio is enabled by default.

.- The regexp that, in case there is %I %O values, agregates them and use them as $size, in case that there isnt' %I %O values, the $size will be the one reported by apache.

The problem is that currently the regexp is working fine when there's no %I %O, but the numbers are not correct when using the logio. Probably someone with stronger abilities in regexp + perl will spot the problem

[aseques]

I've been looking for the dates when the logio was incorportated. This is what I found so far, with this ones it should be working without problems and without enabling anything. Debian lenny --enable-logio=static Ubuntu hardy --enable-logio Ubuntu > hardy: --enable-logio=static

I also recall that on *BSD was build/enabled by default

[aseques]

I've tested the patch by kilburn and it works fine on my systems. Hope it will make into trunk soon.

[nuxwin]

@Benedikt: Please, patch the trunk (single commit for it). So we can test the behavior and revert back changes easily if necessary. Thank

[benedikt]

I will take care of it

[benedikt]

After I checked some distributions, I think every distribution has logio compiled into apache. If not, testers should write a ticket in RC testing stage on error.

added in r3201

[vanshyr]

The regexp don't matches the new variables

[nuxwin]

New version of the ispcp-apache-logger will be committed today.

Note: Sorry, I've reopen the ticket with login credentials that I've created for another user...

[nuxwin]

See r3227