Ticket #2291 (closed defect: fixed)
Invalid counters in ../reseller/index.php
| Reported by: | marchaos | Owned by: | TheCry |
|---|---|---|---|
| Priority: | major | Milestone: | ispCP ω 1.0.7 |
| Component: | Frontend (GUI) | Version: | ispCP ω 1.0.4 |
| Severity: | Medium | Keywords: | |
| Cc: |
Description (last modified by nuxwin) (diff)
If reseller have 3 disabled features it shows like "0 / -3 of unlimited". When he add new user which have 4 aliases for example it shows "0 / 1 of unlimited". It's invalid counters. You need to count only enabled features. May be you can show it like "Max of resseler: unlimited, Enabled: 4, Disabled: 3, With unlimited: 0". Or you can count only users which have not disabled feature.
Next question. If reseller have maximum 5 aliases limit and create 15 users with disabled aliases can he create 20 alises? Or this counters used only for this page?
Change History
comment:2 Changed 23 months ago by marchaos
If we have no users with unlimited but have some users with disabled and some users with enabled feature you must count only numbers bigger than "0".
comment:3 Changed 23 months ago by marchaos
ANY user have unlimited? 1) yes, show "unlimited", end 2) no, continue ALL users have disabled? 1) yes, show "disabled", end 2) no, continue Now we count ONLY which NOT have disabled, end
It's the algorithm for this counters, I hope this will help.
comment:6 Changed 22 months ago by TheCry
Hi marchaos... Did you test the patches? I need a feedback
comment:9 Changed 21 months ago by nuxwin
- Priority changed from normal to patched (close it when ok)
- Severity changed from Don't know to Medium
comment:10 Changed 19 months ago by nuxwin
- Priority changed from patched (close it when ok) to major
- Status changed from assigned to closed
- Resolution set to fixed
- Description modified (diff)
I have better idea. If we have only disabled (-1,-2,-3...) show "disabled", if we have ANY user with unlimited (0) show "unlimited" (because no sense to count summ of infinity and numbers), else show summary used. It's for counters "used". Same for counters "max for resseler".