Ticket #718 (closed defect: fixed)
little design error
| Reported by: | rbtux | Owned by: | benedikt |
|---|---|---|---|
| Priority: | patch | Milestone: | ispCP ω 1.0.4 |
| Component: | Frontend (GUI) | Version: | ispCP ω nightly build |
| Severity: | Medium | Keywords: | design, theme |
| Cc: |
Description
when I launch the domain statistik from within the reseller menu, the design gets broken in the upper right corner...
Attachments
-
users.tpl.patch
(1.9 KB) -
added by TheCry 2 years ago.
- gui/themes/omega_original/reseller/users.tpl
-
before_fix.jpg
(29.2 KB) -
added by TheCry 2 years ago.
-
after_fix.jpg
(29.9 KB) -
added by TheCry 2 years ago.
Change History
comment:2 in reply to: ↑ description Changed 4 years ago by rbtux
it actually happens only with the german language. The symbol description are longer as in the original english.
In englisch there is also a little error. the bar which tells "your logged in as..." as a little to short. but i don't think its worth to fix that...
comment:3 Changed 4 years ago by Joximu
I also use german language and it's ok *until* I resize the browser to small (1024x768 resolution in the dev toolbar) - then it happens to be like rbtux said. Or I increase the font size by two levels...
comment:4 Changed 4 years ago by Joximu
With english language you'll have to downsize the browser to sth like 800x600 for this effect...
comment:5 Changed 4 years ago by rats
- Milestone changed from ispCP ω 1.0.0 - RC3 to ispCP ω 1.1.0
decided to move to 1.1.0 in case of use XHTML 1.0 strict
comment:6 Changed 4 years ago by rats
- Severity set to Hard
- Milestone changed from ispCP ω 1.1.0 to Working
comment:7 Changed 4 years ago by rats
- Priority changed from trivial to minor
- Version changed from ispCP ω 1.0.0 - RC2 to ispCP ω 1.0.0 - DEV
- Milestone changed from Working to ispCP ω 1.1.0
comment:8 Changed 3 years ago by Haeber
With current trunk r1469 and german language I cannot confirm it. The logo and the black background looks good.
comment:9 Changed 2 years ago by joximu
- Status changed from new to closed
- Resolution set to worksforme
- Component changed from Backend (Engine) to Frontend (GUI)
- Severity changed from Hard to Medium
I'd also say: not reproducable in the current versions (I have RC6 - very old).
I'm closing this.
comment:10 Changed 2 years ago by anonymous
- Status changed from closed to reopened
- Resolution worksforme deleted
I have this error too in Demo http://admin.demo.isp-control.net/ under 1024x768 even in English. It need some design optimization for resolution 1024x768.
comment:11 Changed 2 years ago by anonymous
I think we can remove tag "<br>" in message strings like next: msgid "POP3/IMAP<br>traffic". It brokes table. Or we can make tableheader2.jpg for this fields to 56x1 pixels, because tableheader.jpg have 28x1 pixels. Other places of GUI need this optimizations too in some translations. What you think about reduction of words in translations, is this good way?
comment:12 Changed 2 years ago by benedikt
- Cc benedikt@… added
Actually, there is a new Design for ispCP 1.1.0 on the way... we should check, if this problem still exists with this design.
comment:13 Changed 2 years ago by benedikt
- Keywords design, theme added
- Owner set to HenrikS
- Status changed from reopened to new
- Milestone changed from ispCP ω 1.x.0 to ispCP ω 1.1.0
comment:15 Changed 2 years ago by benedikt
- Owner changed from HenrikS to TheCry
Are you able to check this and fix it? if not, please re-assign to HenrikS and the Graph Team should fix it.
comment:16 Changed 2 years ago by TheCry
Is ok... I will take a look on this! No problem
Changed 2 years ago by TheCry
-
attachment
users.tpl.patch
added
gui/themes/omega_original/reseller/users.tpl
comment:18 Changed 2 years ago by TheCry
This patch will fix the problem. I will search for the reason why the table is smaller than the next table. This should be an css problem... But... See this fix as workarround!
comment:19 Changed 2 years ago by TheCry
Ok... Is not a workarround!. I've read a lot about 2 tables one below the other. Why do we need 2 tables? One table is ok!
Please use the patch.
comment:20 Changed 2 years ago by benedikt
this patch is definitively wrong and will break the design. The "Logged From" bas must be a separate table.
comment:21 Changed 2 years ago by TheCry
If you use 2 tables one below the other, you will get this error if the table below the "Logged from" rised up to a size that the first table will not make!
Why does this patch break the design? Now the design is broken. I only use a td which is 100%. We don't need this other table!
Show me one reason why we should use 2 tables one below the other? I don't find any... Look on the template with dreamwaver.. This program will show you the same problem.. Also when you set the table "Logged from" to 100% I will search the reason for this problem and post here
comment:22 Changed 2 years ago by TheCry
Ok... Atfer one hour searching... This effect is comming up, cause the site is not valid and the browser is running i the quirksmode. Open the site and use the command
javascript:alert(document.compatMode)
in the adressline If you see "CSS1Compat" the browser is running in the standardmode. If you see "BackCompat?" the browser is running in the quirksmode.
So... The quirksmode is activated, cause we are not using a Doctype. If the site is not valid and is running in the quirksmode you will get such errors. Think about that.
comment:23 Changed 2 years ago by marchaos
When this will be fixed? Problem still exits in other languages.
comment:24 Changed 2 years ago by TheCry
Which languages? I'd testet with german and french.. I english will this problem not appear!
comment:25 Changed 2 years ago by marchaos
I see this in Russian translation at 1024x768 and in ../reseller/user_statistics.php at 1280x1024. May be in other translations too. I may say this problem exist when the page is bigger then screen resolution.
comment:26 Changed 2 years ago by benedikt
- Owner changed from TheCry to benedikt
- Priority changed from minor to patch
- Status changed from assigned to new
I will try the patch later and commit if it works.
comment:27 Changed 2 years ago by benedikt
- Cc benedikt@… removed
- Status changed from new to assigned
test successful.
comment:28 Changed 2 years ago by benedikt
- Status changed from assigned to closed
- Resolution set to fixed
added in r2569
Can´t confirm that!
Please check it in my Demo. Maybe it has something to do with the German language.