Improve the mysqldump in the Backup

Improve the mysqldump in the Backup - Printable Version

+- ispCP - Board - Support (http://www.isp-control.net/forum)
+-- Forum: ispCP Omega Development Area (/forum-1.html)
+--- Forum: Suggestions (/forum-2.html)
+--- Thread: Improve the mysqldump in the Backup (/thread-1132.html)

Improve the mysqldump in the Backup - BeNe - 08-09-2007 06:39 PM

Hello Community,

i checked the mysqldump function in the backupscript

Code:

/var/www/ispcp/engine/backup/ispcp-backup-all

What do you think about to improve this line (line 292):

Code:

my $db_backupcmd = "$main::cfg{'CMD_MYSQLDUMP'} --add-drop-table -u\'$dbuser\' -p\'$dbpass\' \'$db_name\' >\'$db_backup_file\'";

to this one:

Code:

my $db_backupcmd = "$main::cfg{'CMD_MYSQLDUMP'} --add-drop-table --allow-keywords --quote-names -u\'$dbuser\' -p\'$dbpass\' \'$db_name\' >\'$db_backup_file\'";

Because Joomla (and maybe other webapps) use MySQL functions like "option" or "fulltext" as field name. And without the option " --allow-keywords --quote-names" your are not able to restore your DB. MySQL run into the function and did not interpret it as a field.

Greez BeNe

RE: Improve the mysqldump in the Backup - Zothos - 08-10-2007 03:01 AM

+1 for getting this into the svn Tongue

RE: Improve the mysqldump in the Backup - raphael - 08-10-2007 08:27 AM

will add on my next commit

RE: Improve the mysqldump in the Backup - BioALIEN - 08-15-2007 07:16 PM

Raphael, update this thread or close it once you've committed this so we all know it's resolved Smile

RE: Improve the mysqldump in the Backup - raphael - 08-16-2007 02:47 AM

already commited... and I can't edit posts so BeNe or a mod will have to do it