Current time: 10-22-2021, 08:12 PM Hello There, Guest! (LoginRegister)


Thread Closed 
Improve the mysqldump in the Backup
Author Message
BeNe Offline
Moderator
*****
Moderators

Posts: 5,899
Joined: Jan 2007
Reputation: 68
Post: #1
Improve the mysqldump in the Backup
Hello Community,

i checked the mysqldump function in the backupscript
Code:
/var/www/ispcp/engine/backup/ispcp-backup-all
What do you think about to improve this line (line 292):
Code:
my $db_backupcmd = "$main::cfg{'CMD_MYSQLDUMP'} --add-drop-table -u\'$dbuser\' -p\'$dbpass\' \'$db_name\' >\'$db_backup_file\'";
to this one:
Code:
my $db_backupcmd = "$main::cfg{'CMD_MYSQLDUMP'} --add-drop-table --allow-keywords --quote-names -u\'$dbuser\' -p\'$dbpass\' \'$db_name\' >\'$db_backup_file\'";

Because Joomla (and maybe other webapps) use MySQL functions like "option" or "fulltext" as field name. And without the option " --allow-keywords --quote-names" your are not able to restore your DB. MySQL run into the function and did not interpret it as a field.

Greez BeNe
(This post was last modified: 08-09-2007 06:53 PM by BeNe.)
08-09-2007 06:39 PM
Visit this user's website Find all posts by this user
Zothos Offline
Release Manager
*****
Dev Team

Posts: 1,262
Joined: Feb 2007
Reputation: 10
Post: #2
RE: Improve the mysqldump in the Backup
+1 for getting this into the svn Tongue
08-10-2007 03:01 AM
Find all posts by this user
raphael Offline
Member
***

Posts: 474
Joined: Apr 2007
Reputation: 8
Post: #3
RE: Improve the mysqldump in the Backup
will add on my next commit
08-10-2007 08:27 AM
Visit this user's website Find all posts by this user
BioALIEN Offline
Public Relations Officer
*****
Dev Team

Posts: 620
Joined: Feb 2007
Reputation: 5
Post: #4
RE: Improve the mysqldump in the Backup
Raphael, update this thread or close it once you've committed this so we all know it's resolved Smile
08-15-2007 07:16 PM
Find all posts by this user
raphael Offline
Member
***

Posts: 474
Joined: Apr 2007
Reputation: 8
Post: #5
RE: Improve the mysqldump in the Backup
already commited... and I can't edit posts so BeNe or a mod will have to do it
08-16-2007 02:47 AM
Visit this user's website Find all posts by this user
Thread Closed 


Forum Jump:


User(s) browsing this thread: 1 Guest(s)