Apache just stopped :O!!

[nicolas]

Hi,

I am still investigating the issue. I have been logging all operations during logrotate and still have not found why Apache is stopping and not starting again.

But I came through this file: /etc/logrotate.d/ispcp which contains:

Quote:/var/log/apache2/users/*.log {
weekly
missingok
rotate 52
compress
delaycompress
notifempty
create 640 root adm
sharedscripts
prerotate
/var/www/ispcp/engine/traffic/ispcp-vrl-traff > /var/log/ispcp/ispcp-vrl-traff.log
endscript
postrotate
for i in `seq 1 10`; do
if [ -f /var/run/apache2.pid ]; then
/etc/init.d/apache2 stop > /dev/null
sleep 5
/etc/init.d/apache2 start > /dev/null
fi
done
endscript
}

Is there a particular reason for stopping and starting Apache 10 times ?

[sci2tech]

nicolas Wrote:Is there a particular reason for stopping and starting Apache 10 times ?

Thank you for signaling this. See r1348.

[nicolas]

[/quote]I finally found where the error is! Apache is stopping when instructed in the /etc/logrotate.d/ispcp script, but does not start again, claiming that port 80 is already bound. Here is the error I logged:

Quote:Fri Sep 12 09:08:28 CEST 2008
* Stopping web server apache2
...done.
* Starting web server apache2
(98)Address already in use: make_sock: could not bind to address [::]:80
(98)Address already in use: make_sock: could not bind to address 0.0.0.0:80
no listening sockets available, shutting down
Unable to open logs
...fail!
error: error running shared postrotate script for /var/log/apache2/users/*.log

(I have not logged the time when apache2 tries to start again... I will add it to my logs)

I understand that the part of the script that does:

Quote: for i in `seq 1 10`; do
if [ -f /var/run/apache2.pid ]; then
sleep 5
fi

is not working as it should. Is it possible that the apache2.pid file gets deleted when apache2 stops, but that some requests are still being served (thus leaving the port 80 bound)?

I will try to change the logrotate script from apache stop / start to "/etc/init.d/apache2 restart" and report results here (the /etc/init.d/apache2 restart script includes a 10second sleep and does a gracefull stop start).

Nicolas.

[sci2tech]

apache does not need to be restarted anymore on logrotation if you are using ISPCP from trunk. Do not use restart because is an alias for stop... sleep 10 ... start. Better use apache reload. It did solve my problems. Do not know how apache reload is supported by other distro, thats why I did not modified to use this.

[nicolas]

I am not keen on moving on a trunk release yet (I prefer to wait for the next stable release, to keep things easy to update).

Your solution seems to be exactly what I was looking for. I thought that "apache2 restart" was mandatory after a log rotation but it's not! Under Ubuntu the default script for logrotate.d/apache2 is:

Quote: postrotate
if [ -f "`. /etc/apache2/envvars ; echo ${APACHE_PID_FILE:-/var/run/apache2.pid}`" ]; then
/etc/init.d/apache2 reload > /dev/null
fi

So I guess this is what should be used (at least under Ubuntu).

[nicolas]

This is to confirm that my problem was solved by changing the "apache2 restart" command by a "apache2 reload" in /etc/logrotate.d/apache2 and ispcp files, as it is done by default on Ubuntu.

Best regards and thanks to sci2tech!

[Wut]

(09-17-2008 07:32 PM)nicolas Wrote:  This is to confirm that my problem was solved by changing the "apache2 restart" command by a "apache2 reload" in /etc/logrotate.d/apache2 and ispcp files, as it is done by default on Ubuntu.

Best regards and thanks to sci2tech!

Hi folks,

I found similar problem as nicolas.

I already change "apache2 restart" to "apache2 reload" in /etc/logrotate.d/apache2 but what I should do to /etc/logrotate.d/ispcp ?

My system is debian so nicolas's solution may not work for mine ?

[sci2tech]

(10-16-2008 05:26 PM)Wut Wrote:  Hi folks,
I found similar problem as nicolas.
I already change "apache2 restart" to "apache2 reload" in /etc/logrotate.d/apache2 but what I should do to /etc/logrotate.d/ispcp ?

Same thing. /etc/logrotate.d/apache2 Has nothing to do with ispcp because is not altered in any way by ispcp. In /etc/logrotate.d/ispcp I already did this modifications in the trunk and you should do the same with your installation. Also until ispcp will be stable (and after as well) you should always follow development to see if any modifications done in the trunk is necessary to be implemented in your version of ispcp.

[Wut]

(10-16-2008 08:59 PM)sci2tech Wrote:  

(10-16-2008 05:26 PM)Wut Wrote:  Hi folks,
I found similar problem as nicolas.
I already change "apache2 restart" to "apache2 reload" in /etc/logrotate.d/apache2 but what I should do to /etc/logrotate.d/ispcp ?

Same thing. /etc/logrotate.d/apache2 Has nothing to do with ispcp because is not altered in any way by ispcp. In /etc/logrotate.d/ispcp I already did this modifications in the trunk and you should do the same with your installation. Also until ispcp will be stable (and after as well) you should always follow development to see if any modifications done in the trunk is necessary to be implemented in your version of ispcp.

But there is no "apache2 restart" to change to "apache2 reload" in /etc/logrotate.d/ispcp ?