Ticket #203 No daily Backups were made

[BeNe]

I opend this Thread here, because i can´t reply this Text to the Ticket. Always get an Error.
I hope malte will fix it when he is back @ home.

Here is my reply:
___________________________________________________________

Ok, i see there are some wrong characters in the
file "ispcp-backup-all" under /var/www/ispcp/engine/backup.

Code:

#!/usr/bin/perl

Open this File and change it to:

Code:

#!/usr/bin/perl

now it works for me.

The File in the SVN looks good when i "Browsing Source" here on the side.

I had the same Problem, but only on one Server of two that checked out the lastet trunk. On the other Server the file looks good. Both of the running on Debian Etch.

There are more chracters not displayed correct on the Server with this Error:

Code:

ispCP Ï~I (OMEGA)

and the other Server display it correct and there are no wrong characters
in the ispcp-backup-all.

Code:

ispCP Ï (OMEGA)

Could this might be a problem with locales ?

[joximu]

I can confirm this

the first character in /var/www/ispcp/engine/backup is 0xFEFF (in mcedit you only see it, when moving from the cursor the beginning - in hex-mode you'll see it... - syntax highlighting is disabled in mcedit because of this extra character :-)

The other characters (in this file) seem to be ok...

Seem to be like this since renaming vhcs -> ispCP.
nightly from april 8 is ok, april 14 and april 19 are "broken"

/joximu

[RatS]

was malte's fault I've changed it immediately as I saw it.

[joximu]

But it's still not in SVN (not in the nightly...) - is it?

And: the lock file seems not to be removed when an error happens (unable to connect to SQL server) - I'm searching for the SQL problem, but the lock file should be removed afterwards...)

/joximu

[joximu]

and something more... :-)

when starting the backup manually:

Argument "" isn't numeric in numeric ne (!=) at /home/_www/ispcp/engine/backup/ispcp-backup-all line 285

(I use /home/_www and not /var/www)

it's a comparison:
($rs,my $rdata2) = doSQL($sql);
...
-> if ($rdata2 != "") {

an array is compared to an empty string...

/joximu

[BeNe]

@ joximu: Can please Open a Ticket about these problems ?
Is better than here in the Board.

[joximu]

sure... #207
[edit]
and #208 (the lock file)
[edit]
/joximu

[BeNe]

Good - thanks!

[BeNe]

I tested to restore some Backups through the GUI under Webtools -> Backup.

Code:

Restore backup

Click Restore button and the system will
restore last daily backup

But no Backup is restore!
I only see this text

Code:

Backup archive scheduled for restoring!

I started "/var/www/ispcp/engine/backup/ispcp-backup-all yes &>/var/log/ispcp/ispcp-backup-all-mngr.log" manually.
The logfile is empty and no data is restored.

Can somebody confirm that ?

[BeNe]

I tested it a second time, installation from Scratch on Debian Etch.
After restoring the Backups - i get this Error in the GUI under Status and no Backup is restored:

Code:

sys_command() | ERROR: External command '/bin/tar --extract --bzip2 --directory=/var/www/virtual/mydomain.tld --file=/var/www/virtual/mydomain.tld/backups/..' returned '2' status !

But it works when i do it by Hand with:

Code:

/bin/tar --extract --bzip2 --directory=/var/www/virtual/mydomain.tld/ --file=/var/www/virtual/mydomain.tld/backups/mydomain.tld-backup-2007.04.24-082457.tar.bz2