just added

[raphael]

Quote:If we want to be one of the best cps out there.

we are long away from being a *real* CP

Quote:But! you didnt have a testing maschine. So every change wasnt tested before. Therefor we had a bunch of new bugs If your code would be tested before its commited, then I personaly think its ok .

ack, the main problem was that I've only got to reach isp-control.net's testing server once or twice.

Quote:Dont say, the development isnt going further because of the update script. Ask yourself why you dont help!

did you really read what I said on my post?

Quote:So raphael can spend his time to new features and the other can bring RC3 to the end

an other branch isn't a solution, the problem is that RC1 shouldn't have been released at all; it was bogus, there were plans to make major changes but they still decided to release RC1.

A simple and far better checking script would be this:

Code:

#!/bin/sh

file2Check=/etc/ispcp/ispcp.conf

if [ ! -z "$1" ] && [ -f "$1" ]; then
        file2Check="$1"
fi

[ ! -f "$file2Check" ] && echo "$file2Check couldn't be found!" && exit 1
[ ! -f configs/ispcp.conf ] && echo "configs/ispcp.conf couldn't be found!" && exit 1

VARS=$(egrep "^[a-zA-Z0-9_-]+( )?=" configs/ispcp.conf | cut -d= -f1)

for var in $VARS; do
        if ! egrep "^$var" "$file2Check" > /dev/null; then
                echo "$var was not found in $file2Check"
        fi
done

some test results:

Quote:CMD_CHMOD was not found in configs/dists/redhat/ispcp.conf
CMD_SHELL was not found in configs/dists/redhat/ispcp.conf
APACHE_CUSTOM_SITES_CONFIG_DIR was not found in configs/dists/redhat/ispcp.conf
BACKUP_ISPCP was not found in configs/dists/redhat/ispcp.conf
BACKUP_DOMAINS was not found in configs/dists/redhat/ispcp.conf
DEBUG was not found in configs/dists/redhat/ispcp.conf

Quote:CMD_CHMOD was not found in configs/dists/ubuntu/ispcp.conf
CMD_SHELL was not found in configs/dists/ubuntu/ispcp.conf
APACHE_CUSTOM_SITES_CONFIG_DIR was not found in configs/dists/ubuntu/ispcp.conf

... and those checks should be made at make time (on the 'test' target of course)