Simplify php code

[sci2tech]

Include/login.php

Code:

function unset_user_login_data ($ignorePreserve = false) {
    $sql = Database::getInstance();

    if (isset($_SESSION['user_logged'])) {

        $sess_id = session_id();

        $admin_name = $_SESSION['user_logged'];

        $query = <<<SQL_QUERY
            delete from
              login
          where
              session_id = ?
          and
              user_name = ?
SQL_QUERY;

        $rs = exec_query($sql, $query, array($sess_id, $admin_name));

    }

    $preserve_list = array('user_def_lang', 'user_theme');
    $preserve_vals = array();

    if (!$ignorePreserve) {
        foreach ($preserve_list as $p) {
            if (isset($_SESSION[$p])) {
                $preserve_vals[$p] = $_SESSION[$p];
            }
        }
    }

    $_SESSION = array();

    foreach ($preserve_list as $p) {
        if (isset($preserve_vals[$p])) {
            $_SESSION[$p] = $preserve_vals[$p];
        }
    }

}

can become

Code:

function unset_user_login_data ($ignorePreserve = false) {
    $sql = Database::getInstance();

    if (isset($_SESSION['user_logged'])) {
        $sess_id = session_id();
        $admin_name = $_SESSION['user_logged'];
        $query = "DELETE FROM `login` WHERE `session_id` = ? AND `user_name` = ?";
        $rs = exec_query($sql, $query, array($sess_id, $admin_name));
    }
    $preserve_list = array('user_def_lang', 'user_theme');//may a Config::get here?
    foreach ($_SESSION as $key=>$value)
        if(!in_array($key,$preserve_list)||$ignorePreserve)
            unset($_SESSION[$key])
}