POP3/IMAP Traffic Statics wrong ?

[BeNe]

I started to debug the wrong Traffic stats.
We talk about ALL TrafficStats in ispCP. In my eyes no traffic is really correct

First i found a bug with a wrong secure smtp Port:
--> http://www.isp-control.net/ispcp/ticket/1770
On check the srv_traff_engine i saw this part:

Code:

if (defined($port) && $port > 0) {

                        $smtp_in += $bytes if ($port == 25);

                        $smtp_in += $bytes if ($port == 456);

                        $pop3_in += $bytes if ($port == 110);

                        $pop3_in += $bytes if ($port == 995);

                        $imap_in += $bytes if ($port == 143);

                        $imap_in += $bytes if ($port == 993);

                        $http_in += $bytes if ($port == 80);

                        $http_in += $bytes if ($port == 443);

An in the OUT Part only the half of the Ports are logged ?

Code:

if (defined($port) && $port > 0) {

            $smtp_out = $bytes if ($port == 25);

            $pop3_out = $bytes if ($port == 110);

            $imap_out = $bytes if ($port == 143);

            $http_out = $bytes if ($port == 80);

It this really correct or are the Ports here missing ?

There is also a differnt between DomainTraffic in ispCP and AWstats.
Ok there *could* be a traffic differnce between both, but we talk about hundreds of MB and GB ?!

Still on the way to find out the error.

Greez BeNe