Threaded Mode | Linear Mode

01-17-2010 02:08 PM

(01-15-2010 05:56 PM)MasterTH Wrote: Hi,

i just checked out the current trunk.
Added a new domain. The status doesn't change from toadd to ok. After running the rqst-mngr everything works fine.

Wheres the problem?

Sorry, I can't reproduce it with r2531. I've updated normally, add new domain and all work fine.

(01-16-2010 10:11 AM)MasterTH Wrote: ok, next time i'll try,

got another error message from debugger..
When reseller goes into the ticket-section, this messages is sent to me from ispcp:
Array
File: /var/www/ispcp/gui/reseller/ticket_system.php (Line: 220) Function: exec_query

Error Message in Browser: HY093 (whats wrong with my database?)

Sorry, I can't reproduce it with r2531

(01-17-2010 03:23 AM)marchaos Wrote:
(01-16-2010 11:51 PM)MasterTH Wrote: ok, found a new bug...
statistics doesn't count properly
Theres a bug in the counting system since the laste trunk...

I have the same after update via nightly update script. I saw this bugs. Can't add domain because "addition in progress" don't finish this process. Can't remove domain in this state. IspCP Debugger show "No errors" and "3 Execute requests". When I press "3 Execute requests" nothing changed - there was "3 Execute requests". But when I rebooted the server and use "3 Execute requests" all was ok, domain added and I can remove them after.
Now I have troubles with traffic counting - statistics show zero values.
I create ticket http://www.isp-control.net/ispcp/ticket/2167
I'm not sure may be something wrong with http://www.isp-control.net/ispcp/ticket/2096 , http://www.isp-control.net/ispcp/changeset/2502 ?

Does ispCP daemon need to be only killed? Does "/etc/init.d/ispcp_daemon restart" work correct?

Can somebody rewrite Nightly Update Script for current trunk because "cp ${INST_PREF}${CONF_DIR}/apache/working/ispcp.conf ${CONF_DIR}/apache/working/ispcp.conf"
don't work now? http://www.isp-control.net/documentation...atenightly
May be somebody can integrate this script in ispCP and rewrite this everytime when this changes needed? May be not in GUI but in ispCP package? I create ticket http://www.isp-control.net/ispcp/ticket/2171 Not really needed but nice to have it inside because wrong update script can be danger if ispCP distribution will have big changes in future.

And thanks for your work guys, after some bugs was removed GUI looks really better.

Sorry, I can't reproduce it with r2531

(01-17-2010 03:23 AM)marchaos Wrote: ...
Now I have troubles with traffic counting - statistics show zero values.
I create ticket http://www.isp-control.net/ispcp/ticket/2167
I'm not sure may be something wrong with http://www.isp-control.net/ispcp/ticket/2096 , http://www.isp-control.net/ispcp/changeset/2502 ?

Does ispCP daemon need to be only killed? Does "/etc/init.d/ispcp_daemon restart" work correct?

Can somebody rewrite Nightly Update Script for current trunk because "cp ${INST_PREF}${CONF_DIR}/apache/working/ispcp.conf ${CONF_DIR}/apache/working/ispcp.conf"
don't work now? http://www.isp-control.net/documentation...atenightly
May be somebody can integrate this script in ispCP and rewrite this everytime when this changes needed? May be not in GUI but in ispCP package? I create ticket http://www.isp-control.net/ispcp/ticket/2171 Not really needed but nice to have it inside because wrong update script can be danger if ispCP distribution will have big changes in future.

And thanks for your work guys, after some bugs was removed GUI looks really better.

1. traffic count :
I'll inspect it.

2. Does ispCP daemon need to be only killed?

Normally, restart it's ok but in extreme mesure, you can kill the process manually and then, restart the daemon normally.

3. Nightly Update Script

First, read the NOTICE in the related documentation --> "This Script is for following the Development. It's dsigned for people, where know's what they do!!! We gave no Support for this script. Use it on your own risk!!!"

I've set your ticket as invalid because this script should be used only by experts, not by everyone. If you uses snapshoots of trunk, you accept that can be in broken state. The update script is no maintained officially.

(01-17-2010 07:39 AM)marchaos Wrote: I use the same script on Debian 1.0.3. I updated before without any troubles. "cp ${INST_PREF}${CONF_DIR}/apache/working/ispcp.conf ${CONF_DIR}/apache/working/ispcp.conf" gives error. Is it important file for ispCP or not? I think file not exist now. I don't think troubles maded by nightly update script. May be some bugs in ispCP daemon. Can somebody answer me about restarting daemon by "/etc/init.d/ispcp_daemon restart" or start/stop, does it work correct because I don't have errors when i made this but ispCP debugger still don't execute requests? Errors goes away only after reboot server and "3 Execute requests" used. Nuxwin right, better not integrate nightly update script in ispCP, but small rewrite of this needed. Please find bugs in traffic counting, they are still inside.

Sure, the file ispcp.conf is important. Now, sorry, with normal make process, I can reproduce this bug under Debian Lenny.

For the rest, see my comment above.

(01-17-2010 08:50 AM)marchaos Wrote: Guys, I found bug. /var/log/ispcp/ispcp-srv-traff.log shows:

Code:

Argument "spt" isn't numeric in numeric gt (>) at /var/www/ispcp/engine/traffic/ ispcp-srv-traff line 150. Argument "spt" isn't numeric in numeric gt (>) at /var/www/ispcp/engine/traffic/ ispcp-srv-traff line 150. Argument "spt" isn't numeric in numeric gt (>) at /var/www/ispcp/engine/traffic/ ispcp-srv-traff line 150. .................................................................................................. Argument "dpt" isn't numeric in numeric gt (>) at /var/www/ispcp/engine/traffic/ ispcp-srv-traff line 150. Argument "dpt" isn't numeric in numeric gt (>) at /var/www/ispcp/engine/traffic/ ispcp-srv-traff line 190. Argument "dpt" isn't numeric in numeric gt (>) at /var/www/ispcp/engine/traffic/ ispcp-srv-traff line 190. .................................................................................................. Argument "spt" isn't numeric in numeric gt (>) at /var/www/ispcp/engine/traffic/ ispcp-srv-traff line 190.
Look last changes there http://www.isp-control.net/ispcp/changeset/2502 and there http://www.isp-control.net/ispcp/ticket/2096. And I found topic about this http://www.isp-control.net/forum/thread-8721.html
Does next changes causes errors?

Code:

$port = $1 if ($line =~ /spt\:(\d+) *$/); $port = $1 if ($line =~ /(spt|dpt)\:(\d+) *$/);

I'll inspect it.

Cheers ;

Threaded Mode \| Linear Mode current trunk version daemon not working properly
Author	Message