Domain alias forward edition

[greg]

I don't like the actual form that show domains alias and the system for enable/disable the forward.

The main problem is that the domain alias list don't show the forward url ! We can only see if a forward is set or not with the enable/disable switch (and it's not very clear to understand). But if a forward exist, the redirect url can't be see...

Worst of all, if you click on disable, then the forward is deleted, and you never see the url... no confirmation about this action, and you can only enable the forward again... if you know what the mystery url must be !

I have two little modifications to propose (i'm working with the last nightly) :

Code:

file /var/www/ispcp/gui/reseller/edit_alias.php, line 65 :
//    check_for_disable($_GET['edit_id']);

file /var/www/ispcp/gui/reseller/domain_alias.php, line 346 :
//              $als_fwd = ($als_fwd == 'no') ? tr('disabled') : tr('enabled');

I just comment this two lines to avoid the auto-deletion of existing alias (then you can edit it, and set it to 'no' to disable) and to show the forward url instead of 'disable'/'enable'

Of course the same things would be made into the custumer interface, maybe like this :

file /var/www/ispcp/gui/client/manage_domains.php :

Code:

function gen_user_als_forward($als_id, $als_status, $url_forward)
{
  global $cfg;

  if ($url_forward === 'no') {
    if ($als_status === 'ok') {
//      return array(tr('Enable'), "enable_als_fwd.php?id=$als_id");
      return array(tr('None'), "enable_als_fwd.php?id=$als_id");
    } else {
      return array(tr('N/A'), '#');
    }
  } else {
    if ($als_status === 'ok') {
//    return array(tr('Disable'), "disable_als_fwd.php?id=$als_id");
      return array($url_forward, "enable_als_fwd.php?id=$als_id");
    } else {
      return array(tr('N/A'), '#');
    }
  }
}

What do you think about it ?