mysql dump in ispcp-backup-all broken after password encryption

[ispcomm]

Hi all,

the title says it all: the current implementation of ispcp-backup-all does not decrypt passwords when it needs to dump user databases. The result is that mysqldump cannot connect to the database and the backup is not performed.

A quick solution is to change line 342:

Code:

my $db_backupcmd = "$main::cfg{'CMD_MYSQLDUMP'} --add-drop-table --allow-keywords --quote-names -h\'$main::cfg{'DATABASE_HOST'}\' -u\'$dbuser\' -p\'$dbpass\' \'$db_name\' >\'$db_backup_file\'";

to

Code:

my $db_backupcmd = "$main::cfg{'CMD_MYSQLDUMP'} --add-drop-table --allow-keywords --quote-names -h\'$main::cfg{'DATABASE_HOST'}\' -uroot -proot-password \'$db_name\' >\'$db_backup_file\'";

However a proper solution would be better. I have not opened a ticket for this problem.
ispcomm.

[BeNe]

Should be solved in trunk or not ?
--> http://www.isp-control.net/ispcp/ticket/1729#comment:4
--> http://www.isp-control.net/ispcp/changeset/1582
--> http://www.isp-control.net/ispcp/changeset/1583

Greez BeNe

[ispcomm]

That ticket look nice