Current time: 05-18-2024, 07:36 AM Hello There, Guest! (LoginRegister)


Post Reply 
Hosting plans error or normal behavior?
Author Message
NIIcK Offline
Junior Member
*

Posts: 43
Joined: Jan 2010
Reputation: 0
Post: #1
Hosting plans error or normal behavior?
I have created a plan and set it up as not available for purchasing however if I access it from outside the system (as in going directly to the link) I can purchase the plan and it shows up in the Manage Orders area afterward. Even more, I can enable it and the user can actually get the plan.

If necessary I can send the link to this plan via PM.

Is this as it is supposed to be or am I doing something wrong?

Regards,

Nick
(This post was last modified: 01-26-2010 01:56 AM by NIIcK.)
01-26-2010 01:31 AM
Visit this user's website Find all posts by this user Quote this message in a reply
joximu Offline
helper
*****
Moderators

Posts: 7,024
Joined: Jan 2007
Reputation: 92
Post: #2
RE: Hosting plans error or normal behavior?
which release of ispcp?
01-26-2010 10:10 PM
Visit this user's website Find all posts by this user Quote this message in a reply
NIIcK Offline
Junior Member
*

Posts: 43
Joined: Jan 2010
Reputation: 0
Post: #3
RE: Hosting plans error or normal behavior?
(01-26-2010 10:10 PM)joximu Wrote:  which release of ispcp?

ispCP 1.0.3 OMEGA
build: 20091224
Codename: Priamos
01-26-2010 11:49 PM
Visit this user's website Find all posts by this user Quote this message in a reply
joximu Offline
helper
*****
Moderators

Posts: 7,024
Joined: Jan 2007
Reputation: 92
Post: #4
RE: Hosting plans error or normal behavior?
ok, i'm gonna check on my system.
It seems like this:

in the overview of the plans - the disabled (hided) plans should not be visible:

eg
host/orderpanel/index.php?coid=&user_id=2

but the plan details are visible if someone just tries the id=...:
/orderpanel/package_info.php?id=2&user_id=2

I don't know if this is an error.
Maybe we should have more than two states (public, private, hidden - or similar...)

/Joxi
(This post was last modified: 01-27-2010 12:26 AM by joximu.)
01-27-2010 12:19 AM
Visit this user's website Find all posts by this user Quote this message in a reply
kilburn Offline
Development Team
*****
Dev Team

Posts: 2,182
Joined: Feb 2007
Reputation: 34
Post: #5
RE: Hosting plans error or normal behavior?
Quote:but the plan details are visible if someone just tries the id=...:
/orderpanel/package_info.php?id=2&user_id=2

I don't know if this is an error.

If it's not available for purchase it may or may not show, but nobody should be able to actually order it. Thus, I think that it's a simple bug, where the dev forgot to check if the plan is unavailable before rendering the page. Open a ticket Wink
01-27-2010 12:32 AM
Visit this user's website Find all posts by this user Quote this message in a reply
NIIcK Offline
Junior Member
*

Posts: 43
Joined: Jan 2010
Reputation: 0
Post: #6
RE: Hosting plans error or normal behavior?
Ok, cheers. I'll open a ticket about this.

Cheers,

Nick
and the ticket ...

http://www.isp-control.net/ispcp/ticket/2183
(This post was last modified: 01-27-2010 04:42 AM by NIIcK.)
01-27-2010 04:16 AM
Visit this user's website Find all posts by this user Quote this message in a reply
NIIcK Offline
Junior Member
*

Posts: 43
Joined: Jan 2010
Reputation: 0
Post: #7
RE: Hosting plans error or normal behavior?
The bug has been fixed (thanks kilburn).

The patch, tested by me and found working can be found here:

http://www.isp-control.net/ispcp/ticket/2183 (see the attachment).

Once again, thank you for your fast response!

Great community!

Nick
01-27-2010 11:56 PM
Visit this user's website Find all posts by this user Quote this message in a reply
Post Reply 


Forum Jump:


User(s) browsing this thread: 1 Guest(s)