Current time: 11-23-2024, 08:54 AM Hello There, Guest! (LoginRegister)


Post Reply 
Convert pTemplates into Smarty Templates
Author Message
zpin Offline
Junior Member
*****
Dev Team

Posts: 160
Joined: Sep 2007
Reputation: 1
Post: #21
RE: Convert pTemplates into Smarty Templates
Yes, it's working on all levels. More testing will have to be done since one person alone usually doesn't find all the errors.
A trial period sounds reasonable. My trac username is zpin.
10-01-2010 01:14 AM
Find all posts by this user Quote this message in a reply
tomdooley Offline
Development Team
*****
Dev Team

Posts: 332
Joined: Sep 2007
Reputation: 7
Post: #22
Big Grin RE: Convert pTemplates into Smarty Templates
Hi @zpin,

looks like a great work to start! Smile

Can you provide us a standard (non-git) patch to current trunk? Currently having some trouble to apply the patch file.

EDIT: Got it working and made first tests. Looks promising! Smile

Something more will be useful, escpecially escaping in templates (not in PHP sources), create new default controls by new Smarty plugins, and so on.

Greetz
Thomas
(This post was last modified: 10-03-2010 07:45 PM by tomdooley.)
10-03-2010 06:07 PM
Visit this user's website Find all posts by this user Quote this message in a reply
zpin Offline
Junior Member
*****
Dev Team

Posts: 160
Joined: Sep 2007
Reputation: 1
Post: #23
RE: Convert pTemplates into Smarty Templates
Thanks Smile Good to hear that it works. For anyone else having problems: It should work with the standard patch program, just use the -p1 option because the patch uses special "a/" and "b/" paths to distinguish the files.

I agree that we could use Smarty to implement some further things now. For example moving the whole translation stuff to the templates using:
http://smarty.incutio.com/?page=SmartyGettext
10-03-2010 08:52 PM
Find all posts by this user Quote this message in a reply
zpin Offline
Junior Member
*****
Dev Team

Posts: 160
Joined: Sep 2007
Reputation: 1
Post: #24
RE: Convert pTemplates into Smarty Templates
Is there any news regarding the integration or a SVN account?
10-07-2010 09:32 AM
Find all posts by this user Quote this message in a reply
Zothos Offline
Release Manager
*****
Dev Team

Posts: 1,262
Joined: Feb 2007
Reputation: 10
Post: #25
RE: Convert pTemplates into Smarty Templates
rumors say that this topic will be part of the next team meeting Big Grin
10-07-2010 05:11 PM
Find all posts by this user Quote this message in a reply
zpin Offline
Junior Member
*****
Dev Team

Posts: 160
Joined: Sep 2007
Reputation: 1
Post: #26
RE: Convert pTemplates into Smarty Templates
ok, let's wait for that then Smile
10-07-2010 08:19 PM
Find all posts by this user Quote this message in a reply
Obi_Wan Offline
Junior Member
*****
Dev Team

Posts: 64
Joined: Sep 2007
Reputation: 0
Post: #27
RE: Convert pTemplates into Smarty Templates
Back from hospital now. Is there still any where I could contribute some code or patches?
10-16-2010 10:27 PM
Find all posts by this user Quote this message in a reply
sci2tech Away
Senior Member
****

Posts: 1,285
Joined: Jan 2007
Reputation: 23
Post: #28
RE: Convert pTemplates into Smarty Templates
Post your patches here. I`m sure that zpin will add to branch.
10-17-2010 12:30 AM
Visit this user's website Find all posts by this user Quote this message in a reply
RatS Offline
Project Leader
******

Posts: 1,854
Joined: Oct 2006
Reputation: 17
Post: #29
RE: Convert pTemplates into Smarty Templates
(10-16-2010 10:27 PM)Obi_Wan Wrote:  Is there still any where I could contribute some code or patches?

Check out the zpin-repository and attach the patches there, upload them to a ticket. This would be even better than sci2tech's proposal - which is valid but a bit more work for us.
(This post was last modified: 10-17-2010 12:35 AM by RatS.)
10-17-2010 12:35 AM
Visit this user's website Find all posts by this user Quote this message in a reply
Obi_Wan Offline
Junior Member
*****
Dev Team

Posts: 64
Joined: Sep 2007
Reputation: 0
Post: #30
RE: Convert pTemplates into Smarty Templates
Ok thanks. Then it is time to update my local copy Smile
10-17-2010 12:37 AM
Find all posts by this user Quote this message in a reply
Post Reply 


Forum Jump:


User(s) browsing this thread: 1 Guest(s)