Domain alias forward edition

[RatS]

I hope you guys like my improvement

[greg]

RatS Wrote:I hope you guys like my improvement

Hum... I'm okay for the new file trunk/gui/reseller/domain_alias.php

But I can't see any changes in the two others !?!?

trunk/gui/reseller/edit_alias.php
trunk/gui/client/manage_domains.php

[RatS]

you were to fast, now it's in

[greg]

RatS Wrote:you were to fast, now it's in

Yes the changeset 698 is better than the 697

I like the "Forward" column, it's clear.

It's a good idea to use the action command, I wanted to do something like this but I don't know about the template system right now... Good work ! but...

The 'enable' switch don't work for me in the reseller GUI : the change function can disable but not enable a forward !

And in fact, I don't really like this switch... User can misunderstand it by 'enable'/'disable' the alias domain (not only the forward). I think it's better to use an action like 'Edit' with the same link used in the forward column. Furthermore a swith is dangerous because you can delete a forward too easily.

[RatS]

okay, there is another idea, I'll try!

I hope you like this one, has taken 2 hours to be as it should be!

[BeNe]

Looks very good now!
Great job

[greg]

Yes good job RatS !

Hum... just two remarks...
- one major : on the custumer gui, I have a blank page (with no error) when I try to edit a domain alias... I don't know why
- one minor : maybe you could add a line to indicate the mount point info when editing a domain alias

But I like it, thanks a lot

[RatS]

greg Wrote:- one major : on the custumer gui, I have a blank page (with no error) when I try to edit a domain alias... I don't know why

cannot reproduce.

greg Wrote:- one minor : maybe you could add a line to indicate the mount point info when editing a domain alias

changed in r707

[greg]

RatS Wrote:

greg Wrote:- one major : on the custumer gui, I have a blank page (with no error) when I try to edit a domain alias... I don't know why

cannot reproduce.

Argh... as for me, I can reproduce it everytime !

I have installed the last nighty build (20070717) and I have the same problem.

The page /client/edit_alias.php?edit_id=6 is always blank
If I ask my browser to show me the source, I have only this :

Code:

<!--
    Compression level: 8
    Original size: 0 kb
    New size: 0.01 kb
    Saving: -0.01 kb (0 %)
    Time: 0.24 ms
    Serverload: 0.09
-->

I have no PHP errors, nothing wrong in the log files... The code seems to be executed till the end (if I add some print into the php source, I can see them, but nothing else)...

I really don't know what is my problem with this page...
Do you have an idea ? Can I try something to debug it ?