Some Tickets

[joximu]

#555:
I added the last part (patch for ispcp-mbox-mngr) so this should be solved.
It works in my installation.
Please test it and close the ticket - I wonder who is the next dev with svn access who is available...

/Joxi

[RatS]

at least I'll do it on Thursday; atm I've to look forward to pass my exam.

[joximu]

Hi RatS
do your best in your exam - this is important!

Who else have svn access? (besides ephigenie and raphael (and you))...?

Joximu

[joximu]

#717:
I added a patch, it was only a false "check for error" in the routines...

/Joximu

[joximu]

#672: see http://www.isp-control.net/forum/php5-id...-1403.html (german). I'd say: for version 1.0 we don't use the idn.so functions. It runs well with the IDN class. We can switch to the odn.so funkctions later...

/Joximu

[Breaki]

fixed #711

@RatS: Good luck on your exams

[Breaki]

The Bruteforce Patch was added yesterday afternoon, maybe RatS has not seen it to implement it to the last r824. So this should be a reminder

#670 Fixed

[BeNe]

Damn - not really.
There was only a "r" missing ?

Thanks again @Breaki.

Greez BeNe

[Zothos]

Back to business guys ^^

We have 4 tickets left till RC3, so lets start.
#55 Update Script from VHCS 2.4.7.1 to ispCP ω 1.0.0
#924 Alias order notification sent to customer
#926 vhcs 2.4.71 update no apache config
#928 vhcs update bind not changed

Rats needs some testing for his upgrade script. And if you know someone whos a god in perl, please ask him if he may help us a bit

Im currently working on #924. But the error is hiding in very ugly code XD
Someone interested to help me a bit?

#926 and #928 is related to rats, help him!

Lets get ispCP RC3 out until new Year guys!!!!

[joximu]

924:

it's in function send_alias_order_email in include/reseller-functions.php

$from and $to are changed for the mail things...

this works for me:

Code:

function send_alias_order_email($alias_name)
{
        global $cfg, $sql;

        $user_id = $_SESSION['user_id'];

        $reseller_id = who_owns_this($user_id, 'user');

        $query = 'SELECT fname,lname FROM admin WHERE admin_id = ?';
        $rs = exec_query($sql, $query, $user_id);
        $ufname = $rs->fields['fname'];
        $ulname = $rs->fields['lname'];
        $uemail = $_SESSION['user_email'];

        $data = get_alias_order_email($reseller_id);
        $to_name = $data['sender_name'];
        $to_email = $data['sender_email'];
        $subject = $data['subject'];
        $message = $data['message'];

        // to
        if ($to_name) {
                $to = "\"" . encode($to_name) . "\" <" . $to_email . ">";
        } else {
                $to = $to_email;
        }

        // from
        if ($ufname && $ulname) {
                $from_name = "$ufname $ulname";
                $from = "\"" . encode($from_name) . "\" <" . $uemail . ">";
        } else {
                if ($ufname) {
                        $from_name = $ufname;
                } else if ($ulname) {
                        $from_name = $ulname;
                } else {
                        $from_name = $uname;
                }
                $from = $uemail;
        }
        $search = array();
        $replace = array();

        $search [] = '{RESELLER}';
        $replace[] = $to_name;
        $search [] = '{CUSTOMER}';
        $replace[] = $from_name;
        $search [] = '{ALIAS}';
        $replace[] = $alias_name;
        $search [] = '{BASE_SERVER_VHOST}';
        $replace[] = $cfg['BASE_SERVER_VHOST'];

        $subject = str_replace($search, $replace, $subject);
        $message = str_replace($search, $replace, $message);

        $subject = encode($subject);

        $headers = "From: ". $from ."\n";
        $headers .= "MIME-Version: 1.0\n" . "Content-Type: text/plain; charset=utf-8\n" . "Content-Transfer-Encoding: 8bit\n" . "X-Mailer: ispCP " . $cfg['Version'] . " Service Mailer";

        $mail_result = mail($to, $subject, $message, $headers);

        $mail_status = ($mail_result) ? 'OK' : 'NOT OK';

}

could someone check this?

/J