Improve the mysqldump in the Backup

[BeNe]

Hello Community,

i checked the mysqldump function in the backupscript

Code:

/var/www/ispcp/engine/backup/ispcp-backup-all

What do you think about to improve this line (line 292):

Code:

my $db_backupcmd = "$main::cfg{'CMD_MYSQLDUMP'} --add-drop-table -u\'$dbuser\' -p\'$dbpass\' \'$db_name\' >\'$db_backup_file\'";

to this one:

Code:

my $db_backupcmd = "$main::cfg{'CMD_MYSQLDUMP'} --add-drop-table --allow-keywords --quote-names -u\'$dbuser\' -p\'$dbpass\' \'$db_name\' >\'$db_backup_file\'";

Because Joomla (and maybe other webapps) use MySQL functions like "option" or "fulltext" as field name. And without the option " --allow-keywords --quote-names" your are not able to restore your DB. MySQL run into the function and did not interpret it as a field.

Greez BeNe

[Zothos]

+1 for getting this into the svn

[raphael]

will add on my next commit

[BioALIEN]

Raphael, update this thread or close it once you've committed this so we all know it's resolved

[raphael]

already commited... and I can't edit posts so BeNe or a mod will have to do it