Current time: 05-04-2024, 01:52 PM Hello There, Guest! (LoginRegister)


Post Reply 
ispCP about php5.3.0
Author Message
fhawk Offline
Junior Member
*

Posts: 29
Joined: Mar 2009
Reputation: 1
Post: #1
ispCP about php5.3.0
ispCP don't support php5.3.0!!
08-21-2009 02:03 AM
Visit this user's website Find all posts by this user Quote this message in a reply
sci2tech Away
Senior Member
****

Posts: 1,285
Joined: Jan 2007
Reputation: 23
Post: #2
RE: ispCP about php5.3.0
I can only found 1 problem. I`ll correct it in trunk. If you find more please post here.
08-21-2009 03:18 AM
Visit this user's website Find all posts by this user Quote this message in a reply
joximu Offline
helper
*****
Moderators

Posts: 7,024
Joined: Jan 2007
Reputation: 92
Post: #3
RE: ispCP about php5.3.0
@sci2tech

could you also check this, see
http://www.isp-control.net/forum/thread-7229.html

Thanx

/J

But be aware: this bug is really old (from vhcs) and therefore I think that the part of the code never run normal...
(This post was last modified: 08-21-2009 08:28 AM by joximu.)
08-21-2009 08:27 AM
Visit this user's website Find all posts by this user Quote this message in a reply
sci2tech Away
Senior Member
****

Posts: 1,285
Joined: Jan 2007
Reputation: 23
Post: #4
RE: ispCP about php5.3.0
It was solved in my last commit. Please test.
08-21-2009 04:41 PM
Visit this user's website Find all posts by this user Quote this message in a reply
joximu Offline
helper
*****
Moderators

Posts: 7,024
Joined: Jan 2007
Reputation: 92
Post: #5
RE: ispCP about php5.3.0
I still think this substr should be a strpos on line 279:
Code:
$curl_b = substr($data, (int) '{', $start_from);
better:
Code:
$curl_b = strpos($data, '{', $start_from);

because you find several other lines like this and an (int) '{' makes no sense (well, only for the syntax...)
But - as I wrote - since this bug is old, I think the whole following block was never run because $curl_b always was false/0/empty...
I can dig into it sometime and check the parts where this function is called.

/J
(This post was last modified: 08-21-2009 05:13 PM by joximu.)
08-21-2009 05:13 PM
Visit this user's website Find all posts by this user Quote this message in a reply
sci2tech Away
Senior Member
****

Posts: 1,285
Joined: Jan 2007
Reputation: 23
Post: #6
RE: ispCP about php5.3.0
I`ll take a deeper look. I just make a quick change to make it work, but never have a deep look at it.
08-21-2009 09:01 PM
Visit this user's website Find all posts by this user Quote this message in a reply
Post Reply 


Forum Jump:


User(s) browsing this thread: 1 Guest(s)