Current time: 12-24-2024, 10:08 AM Hello There, Guest! (LoginRegister)


Post Reply 
How to submit patch
Author Message
traise Offline


Posts: 1
Joined: Jul 2007
Reputation: 0
Post: #1
How to submit patch
Hi dear developers,

I got a problem during ispcp-setup. The script did not accept my FQDN hosting.my.domain.com, so I made a modification to it in order to handle long hostname cause for the moment the script only accept this form "my.domain.com".

.txt  ispcp-setup.patch.txt (Size: 410 bytes / Downloads: 6)

I've send it to malte@... but I did not get any feedback.

What's the best way to send you patch ?

In addition I would like to know how can I get access to SVN in order to help you in ispCPOmega project.
I'm working for a swiss company who provide hosting so I am very interested to participate to this project.

Thank you,
(This post was last modified: 07-22-2007 12:21 AM by traise.)
07-22-2007 12:11 AM
Visit this user's website Find all posts by this user Quote this message in a reply
BeNe Offline
Moderator
*****
Moderators

Posts: 5,899
Joined: Jan 2007
Reputation: 68
Post: #2
RE: How to submit patch
Hello traise,

the best way is to open a Ticket --> here . Write your Info down and Upload your Diff to the Ticket.

For the SVN-Access, check RatS or ephigenie.
It would be perfect if you can help here Smile

Greez BeNe
07-22-2007 02:36 AM
Visit this user's website Find all posts by this user Quote this message in a reply
raphael Offline
Member
***

Posts: 474
Joined: Apr 2007
Reputation: 8
Post: #3
RE: How to submit patch
You should created the patches by using diff -urN; otherwise it is more complicated to be accepted (specially when the file has been modified)
07-22-2007 08:22 AM
Visit this user's website Find all posts by this user Quote this message in a reply
RatS Offline
Project Leader
******

Posts: 1,854
Joined: Oct 2006
Reputation: 17
Post: #4
RE: How to submit patch
with latest trunk your Hostname should work; it's

Code:
    if ($rdata =~ /^((([\w][\w-]{0,253}[\w])\.)*)([\w][\w-]{0,253}[\w])\.([a-zA-Z]{2,6})$/) {

         $main::ua{'hostname'} = $rdata;
         $main::ua{'hostname_local'} = ( ($1) ? $1 : $4);
         $main::ua{'hostname_local'} =~ s/^([\w][\w-]{0,253}[\w])\.(.*?)$/$1/;
(This post was last modified: 07-22-2007 07:20 PM by RatS.)
07-22-2007 07:16 PM
Visit this user's website Find all posts by this user Quote this message in a reply
Post Reply 


Forum Jump:


User(s) browsing this thread: 1 Guest(s)